Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(electron): spellcheck setting #8730

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Nov 7, 2024

fix AF-1647

Copy link

graphite-app bot commented Nov 7, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Nov 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Nov 7, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 35f3fc7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@pengx17 pengx17 changed the base branch from xp/11-07-fix_core_add_open_in_app_hint_text to graphite-base/8730 November 7, 2024 04:10
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.28%. Comparing base (b374924) to head (35f3fc7).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8730      +/-   ##
==========================================
+ Coverage   70.20%   70.28%   +0.07%     
==========================================
  Files         549      549              
  Lines       33891    33891              
  Branches     3042     3042              
==========================================
+ Hits        23794    23819      +25     
+ Misses       9727     9701      -26     
- Partials      370      371       +1     
Flag Coverage Δ
server-test 77.18% <ø> (+0.06%) ⬆️
unittest 45.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the graphite-base/8730 branch from d83164d to 727130e Compare November 7, 2024 04:25
@pengx17 pengx17 force-pushed the xp/11-07-feat_electron_spellcheck_setting branch from 673f24a to 5759026 Compare November 7, 2024 04:25
@pengx17 pengx17 changed the base branch from graphite-base/8730 to canary November 7, 2024 04:26
@pengx17 pengx17 force-pushed the xp/11-07-feat_electron_spellcheck_setting branch from 5759026 to 43da48b Compare November 7, 2024 04:26
@pengx17 pengx17 force-pushed the xp/11-07-feat_electron_spellcheck_setting branch from 43da48b to 6829bd5 Compare November 7, 2024 15:20
@github-actions github-actions bot added mod:i18n Related to i18n app:core labels Nov 7, 2024
@pengx17 pengx17 marked this pull request as ready for review November 7, 2024 15:27
@graphite-app graphite-app bot requested review from JimmFly, EYHN and CatsJuice and removed request for CatsJuice November 7, 2024 15:27
@graphite-app graphite-app bot requested a review from forehalo November 7, 2024 15:27
@pengx17 pengx17 requested a review from CatsJuice November 7, 2024 15:30
@pengx17 pengx17 force-pushed the xp/11-07-feat_electron_spellcheck_setting branch from 6829bd5 to 8402437 Compare November 10, 2024 05:07
@pengx17 pengx17 force-pushed the xp/11-07-feat_electron_spellcheck_setting branch from 8402437 to b0024a1 Compare November 11, 2024 12:47
Copy link

graphite-app bot commented Nov 11, 2024

Merge activity

@pengx17 pengx17 force-pushed the xp/11-07-feat_electron_spellcheck_setting branch from b0024a1 to 35f3fc7 Compare November 11, 2024 13:03
@graphite-app graphite-app bot merged commit 35f3fc7 into canary Nov 11, 2024
46 checks passed
@graphite-app graphite-app bot deleted the xp/11-07-feat_electron_spellcheck_setting branch November 11, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app mod:i18n Related to i18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants